Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use UTC time for packet timeout error #4467

Closed
wants to merge 1 commit into from
Closed

fix: use UTC time for packet timeout error #4467

wants to merge 1 commit into from

Conversation

GAtom22
Copy link
Contributor

@GAtom22 GAtom22 commented Aug 25, 2023

Description

Problem

When using a timeout timestamp, the packet timeout error message will return a different time depending on the node's timezone configuration.

For example, for the same packet, we'll have:

In a node with CET timezone:

receiving chain block timestamp >= packet timeout timestamp (2023-08-09 14:12:07.556572046 +0200 CEST >= 1970-01-01 01:00:00.00001 +0100 CET): packet timeout

In a node with UTC timezone:

receiving chain block timestamp >= packet timeout timestamp (2023-08-09 12:12:07.556572046 +0000 UTC >= 1970-01-01 00:00:00.00001 +0000 UTC): packet timeout

Solution

Unify this using UTC timezone independently of server timezone configuration

closes: #XXXX

Commit Message / Changelog Entry

type: commit message

see the guidelines for commit messages. (view raw markdown for examples)


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md).
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/).
  • Added relevant godoc comments.
  • Provide a commit message to be used for the changelog entry in the PR description for review.
  • Re-reviewed Files changed in the Github PR explorer.
  • Review Codecov Report in the comment section below once CI passes.

@crodriguezvega
Copy link
Contributor

Thank you, @GAtom22. Could you please target main instead of release/v7.2.x? Then we can backport the fix. Would you like to have a new patch release of v7.2.x that includes this fix? We are about to release v7.3.0 (end of this week at the latest), would it be possible to use that version instead? v7.3.0 will contains the optional interfaces that applications can implement to enable callbacks through the callbacks middleware.

@GAtom22
Copy link
Contributor Author

GAtom22 commented Aug 28, 2023

Hi @crodriguezvega. Sure, will open a PR to add these changes to main.
We need to have this patch in v7.2.x.
We'll greatly appreciate if you can backport these changes to the release/v7.2.x branch

@GAtom22
Copy link
Contributor Author

GAtom22 commented Aug 28, 2023

Here's the PR to add these changes to main

@GAtom22 GAtom22 closed this Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants